fix: unescape([\\])

isaacs · Mar 1, 2023 · c66be9e · c66be9e
1 parent 0c19f58
commit c66be9e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/unescape.ts b/src/unescape.ts
@@ -21,5 +21,5 @@ export const unescape = (
 ) => {
   return windowsPathsNoEscape
     ? s.replace(/\[([^\/\\])\]/g, '$1')
-    : s.replace(/((?!\\).|^)\[([^\/])\]/g, '$1$2').replace(/\\([^\/])/g, '$1')
+    : s.replace(/((?!\\).|^)\[([^\/\\])\]/g, '$1$2').replace(/\\([^\/])/g, '$1')
 }
diff --git a/test/escape-has-magic.js b/test/escape-has-magic.js
@@ -25,5 +25,8 @@ for (const p of patterns) {
   t.matchSnapshot([maybeMagic.set, maybeMagic.hasMagic()], pattern)
 }
 
+// edge case, [\\] should be unescaped as [], not \\
+t.equal(unescape('[\\]'), '[]')
+
 t.equal(new Minimatch('{a,b}').hasMagic(), false)
 t.equal(new Minimatch('{a,b}', { magicalBraces: true }).hasMagic(), true)