Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Make Child Pull Requests Dependent on Parent Pull Requests #867

Open
rbcasperson opened this issue Jan 30, 2017 · 7 comments
Open

Make Child Pull Requests Dependent on Parent Pull Requests #867

rbcasperson opened this issue Jan 30, 2017 · 7 comments
Labels
cross referencing Interlinking between issues, prs, commits, etc enhancement github/feedback Also filed in or related to official github/feedback repo pull-requests

Comments

@rbcasperson
Copy link

GitHub currently allows you to change the base branch of a pull request, which would allow you chain pull requests together so that the unique diff can be seen. The issue with this is that it only works with upstream branches.

I would like to have the ability to mark a Pull Request as a Child of another pull request. In this case the child PR would not be able to be merged until the parent is merged or the marking is changed. Also, the diff would only show the differences in regards to the parent PR.

These features are not possible when continuously working on a feature or set of features that depend on each other and require review merging one piece at a time a branch or number of branches ON A FORKED BRANCH. This often leaves me having to manually manage a chain of branches on a local repo, getting feedback on one piece at a time without a reviewer being able to see the upcoming changes as well.

@rbcasperson rbcasperson changed the title Make child Pull Requests dependent on parent pull requests Make Child Pull Requests dependent on Parent Pull Requests Jan 30, 2017
@rbcasperson rbcasperson changed the title Make Child Pull Requests dependent on Parent Pull Requests Make Child Pull Requests Dependent on Parent Pull Requests Jan 30, 2017
@aspiers
Copy link
Collaborator

aspiers commented Apr 2, 2018

Duplicates: #950 and #959.

@oprogramador
Copy link

@isaacs

could you close this issue because as @aspiers states, it's a duplicate

@dgw
Copy link

dgw commented Feb 28, 2019

@oprogramador The issues @aspiers mentioned are the duplicates. This one existed first.

@aspiers
Copy link
Collaborator

aspiers commented Feb 28, 2019

@dgw commented on February 28, 2019 12:13 AM:

@oprogramador The issues @aspiers mentioned are the duplicates. This one existed first.

That is correct, and I just closed #950. OTOH #959, while newer than this one, has for some reason attracted considerably more attention via up-votes and debate. So I'm inclined to close this one as the duplicate in order to focus attention on the issue with the largest audience and existing detail. @cirosantilli @TPS @clarkbw what do you think?

@cgruber
Copy link

cgruber commented Aug 6, 2019

Very interested in this feature, as it's the main differentiator for other review systems, and is at least a soft-blocker to migrating to github enterprise, as losing this would be a major shift in workflow.

@sbrocket
Copy link

sbrocket commented Jul 2, 2021

Created a thread for this in the new feedback repo: community/community#4477

@aspiers
Copy link
Collaborator

aspiers commented Jul 2, 2021

As per above, #959 is the main issue covering this topic, not this one. Also note that GitHub are in the middle of migrating the most popular issues from this repo to their feedback repo, so while the initiative is appreciated, it's probably better to let them take care of this (unless of course you are part of the GitHub team, in which case I would have other suggestions).

@aspiers aspiers added the github/feedback Also filed in or related to official github/feedback repo label Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cross referencing Interlinking between issues, prs, commits, etc enhancement github/feedback Also filed in or related to official github/feedback repo pull-requests
Projects
None yet
Development

No branches or pull requests

6 participants