Add UPnP and NAT-PMP support

[Ansa89]

This supersedes #1537 and is partially a rebase of #969.

[Ansa89]

TOX_TRAVERSAL_TYPE should be defined directly into toxcore/tox.h.
This is a bad error, I will try to fix it ASAP.

[Ansa89]

TOX_TRAVERSAL_TYPE should be defined directly into toxcore/tox.h.
This is a bad error, I will try to fix it ASAP.

Done.

[alexbakker]

Just tested this and it seems to work.

It would be nice if this UPnP functionality could also map options.tcp_port to make it easier for users to host TCP relays without changing settings in their router.

[Ansa89]

It would be nice if this UPnP functionality could also map options.tcp_port to make it easier for users to host TCP relays without changing settings in their router.

Done.

[cebe]

I'm getting the following warning on make:

  CC       ../toxcore/libtoxcore_la-nat_traversal.lo
../toxcore/nat_traversal.c: In function 'upnp_map_port':
../toxcore/nat_traversal.c:70:13: warning: incompatible implicit declaration of built-in function 'snprintf'
             snprintf(portstr, sizeof(portstr), "%d", port);
             ^

[cebe]

Compiled this with uTox and UPNP works as expected. Code looks also good to me, except the warning as commented above. My router does not support NAT-PMP so I could not test that.

[Ansa89]

@cebe: should be fixed now. Please test again.

[GrayHatter]

I'll test this some time this week!

[alexbakker]

@GrayHatter any news?

[GrayHatter]

No, haven't had the time. Don't let that discourage you from bumping this
PR.
On Apr 10, 2016 4:22 AM, "Impyy" notifications@github.com wrote:

@GrayHatter https://github.com/GrayHatter any news?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1539 (comment)

[GrayHatter]

Is there a way to disable UPnP at runtime?

Eg if I'm on a network I don't want to open ports on?

[cebe]

@GrayHatter set traversal_type option, when creating a new tox object: https://github.com/irungentoo/toxcore/pull/1539/files#diff-6ed9b859959c69656a6ec2bf5ba110adR421

So this can be a dropdown in connection settings of the client.

[Ansa89]

What @cebe said is correct, but the correct link to the code is https://github.com/irungentoo/toxcore/pull/1539/files#diff-a58028aec4211a18b170732935eba2e3R445 (tox.in.h vs tox.h).

[GrayHatter]

this is now merged into new

Thanks @Ansa89

[Ansa89]

Nice, thanks.