Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine usage of POSIX signals. #459

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Redefine usage of POSIX signals. #459

merged 1 commit into from
Nov 7, 2023

Conversation

chschnell
Copy link
Contributor

Use signal SIGUSR1 instead of SIGHUP to detect when to rotate the pcap dump file. Use signal SIGHUP instead of SIGCONT to detect when the controlling terminal closed.

This signal usage provides that sngrep closes cleanly when its controlling (SSH) terminal closes.

This pull request resolves #458.

Use signal SIGUSR1 instead of SIGHUP to detect when to rotate the pcap dump file.
Use signal SIGHUP instead of SIGCONT to detect when the controlling terminal closed.

This signal usage provides that sngrep closes cleanly when its controlling (SSH) terminal closes.
@Kaian Kaian self-requested a review October 25, 2023 07:53
@Kaian Kaian self-assigned this Oct 25, 2023
@Kaian Kaian merged commit ba59a9d into irontec:master Nov 7, 2023
@Kaian
Copy link
Member

Kaian commented Nov 7, 2023

Thanks a lot for your contribution!

@chschnell
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sngrep should not use SIGHUP for dump file rotation
2 participants