Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for hyper/ssl #37

Closed
wants to merge 1 commit into from
Closed

Conversation

jethrogb
Copy link

This is mimicking the setup Iron has. Unfortunately cargo unifies features between dependencies and dev-dependencies (rust-lang/cargo#1796 and rust-lang/cargo#2596). This means that currently, when using iron-test, it's not possible to use hyper without the ssl feature. This PR fixes that.

@jethrogb
Copy link
Author

I don't think travis failure is due to this PR.

@shssoichiro
Copy link

shssoichiro commented Dec 26, 2016

Is there any reason this PR can't be merged? I need this PR (or the one below it that is nearly identical) merged in so that iron-test won't pull in hyper's cookie dependency (which pulls in openssl ^0.7, which causes version conflicts with reqwest which uses openssl ^0.9). hyper's default features pull this in, but I don't believe iron-test needs it.

I'm dealing with it by putting iron-test in my dev-dependencies, but my CI builds are failing as a result (OS X ignores the openssl version conflict and builds, but Linux fails to compile).

Edit: My Linux deployments are failing as well, the build fails even if iron-test is in dev-dependencies, even if not running tests.

@reem
Copy link
Member

reem commented Jan 21, 2017

I believe this is stale, but please feel free to re-open/fix conflicts if that's wrong!

@reem reem closed this Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants