Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build steps #1195

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Fix CI build steps #1195

merged 2 commits into from
Apr 5, 2022

Conversation

mat-if
Copy link
Contributor

@mat-if mat-if commented Apr 4, 2022

Summary

https://github.com/iron-fish/ironfish/actions/runs/2092061971 Ran without the publish step

Two different build issues surfacing at about the same time:

  1. napi-rs released newer versions, and apparently newer versions of docker images which were causing build errors since we aren't using that updated version yet. Fixed this by pinning to last known good docker image versions
  2. github decided to publish updated versions of their ubuntu runner which included an update of npm from 8.3.1 to 8.5.0 which includes a breaking change causing workspace settings to cascade
    Related PR: feat(deps): @npmcli/config@3.0.0 - introduce automatic workspace roots npm/cli#4372
    Issue: [BUG] npm install in a workspace project ignores the workspace npm/cli#2546
    Fixed this by adding the --no-workspaces flag when building ironfish-rust-nodejs package via npm

Testing Plan

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes
[ ] No

@mat-if mat-if requested a review from a team as a code owner April 4, 2022 20:23
@mat-if mat-if merged commit ba7b2ce into staging Apr 5, 2022
@mat-if mat-if deleted the mat/pin-napi-docker-images branch April 5, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants