ServiceX Exploratory Notebook #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-held
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Some very minor comments, happy to get this merged.
The next step for SX is to automate the code (which will make it less readable) for doing similar branches that are done for the uproot version..
We'll certainly have to think of a good way to handle all this. The PHYSLITE schema introduces similar challenges where jet kinematics are living in the Jets object, e.g. Jets.eta, but the raw branch names in uproot are e.g. "AnalysisJetsAuxDyn.eta". We'll have to freeze branch names at some point for efficient XCache use but some initial room for freedom and experimentation would be useful.
gordonwatts
commented
Mar 31, 2024
gordonwatts
added a commit
that referenced
this pull request
Apr 2, 2024
* Use `uproot.dask` directly to open up files rather than letting the automaticed process take care of it. This fixed the bug. * Remove the awkward array restriction * Update documentation to note the removal of the limitation
gordonwatts
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uprootversionThe next step for SX is to automate the code (which will make it less readable) for doing similar branches that are done for the
uprootversion..Fixes #3