Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS example with ServiceX 3 client #225

Merged
merged 23 commits into from
Oct 29, 2024

Conversation

ponyisi
Copy link
Contributor

@ponyisi ponyisi commented Sep 12, 2024

This works with uproot-raw right now with servicex==3.0.0b1. The func_adl version does not yet work (@gordonwatts is working on this), and in the end we would want a version with the final 3.0.0 release.

@ponyisi
Copy link
Contributor Author

ponyisi commented Sep 13, 2024

I've pushed the fixes for the func_adl version of the CMS notebook, with fixes courtesy of @gordonwatts (this needs func_adl >= 3.3.3).

I would like to update the ATLAS example as well, but it seems that at the moment there are problems with the UNL storage which prevent me from accessing those files.

@ponyisi
Copy link
Contributor Author

ponyisi commented Sep 14, 2024

I have updated the ATLAS examples.

* link additional AGC-related projects

* update website

* exclude notebooks from ruff CI

* formatting
@alexander-held
Copy link
Member

The issue with the CI complaining about unrelated files should be fixable by rebasing to incorporate #226.

@alexander-held
Copy link
Member

In the CMS ttbar notebook after the ServiceX delivery cell I see

Method Zip not found on object <class 'types.dict_dataclass'>

What is this about?

@alexander-held
Copy link
Member

Other than the small things about imports above, could we please keep ServiceX off by default with USE_SERVICEX = FALSE to make the notebook work by default with the least amount of dependencies?

One more very picky request: could we please move USE_SERVICEX_DOWNLOAD into utils/config.py (probably into the global section) in an attempt to limit the amount of things to be configured in the notebook directly?

@ponyisi
Copy link
Contributor Author

ponyisi commented Oct 3, 2024

In the CMS ttbar notebook after the ServiceX delivery cell I see

Method Zip not found on object <class 'types.dict_dataclass'>

What is this about?

This is a particular issue related to how func_adl interprets the query, I know @gordonwatts is looking into it.

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me, thank you very much! I believe @oshadura wanted to ensure we can run this on the Open Data coffea-casa before merging but I'll let her comment.

Copy link
Member

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on https://coffea-opendata.casa with new ServiceX! thanks for the patience! :)

@alexander-held alexander-held merged commit 62f51e7 into iris-hep:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants