Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conda environment file that works for Python 3.11 #141

Closed
wants to merge 1 commit into from

Conversation

eguiraud
Copy link
Contributor

The current requirements.txt does not work for 3.11 because of the specified versions of llvmlite and numba.

This might not be the best env for Python 3.11, that is, most packages could probably be upgraded to newer versions, but at least this env runs.

The current requirements.txt does not work for 3.11 because
of the specified versions of llvmlite and numba.

This might not be the _best_ env for Python 3.11, that is, most
packages could probably be upgraded to newer versions, but at
least this env runs.
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a conda environment file and not just a requirements.txt as you're installing everything from PyPI? As most of these packages are available on conda-forge is there a reason to not install them from there and then only install any remainders from PyPI?

@alexander-held
Copy link
Member

The idea behind that was fixing the Python version as well, since with the previous file the switch in Python versions caused issues.

I think we should have a single list to maintain though, so if we switch to this, then also drop the old requirements.txt.

@matthewfeickert
Copy link
Member

I think we should have a single list to maintain though, so if we switch to this, then also drop the old requirements.txt.

If you switch to using lock files then this becomes much easier to even maintain multiple high level environment files and then let the locking system solve the full environment. c.f. https://github.com/iris-hep/analysis-systems-base

@eguiraud
Copy link
Contributor Author

This PR is basically just to document that 3.11 does not work with the current requirements.txt and that it does with something like this conda env. I agree this is still not the best setup 😄

@matthewfeickert did you mean to say noxfile rather than lock file? or: what is a python lock file?

@eguiraud
Copy link
Contributor Author

aaah found it, https://github.com/conda/conda-lock

@eguiraud
Copy link
Contributor Author

For future reference these are the packages that are not available via conda and conda-forge:

fastjsonschema
func-adl
func-adl-servicex
ipython-genutils
jupyter-console
jupyter-events
jupyterlab-pygments
jupyterlab-widgets
make-it-sync
mplhep-data
msgpack
notebook_shim
prometheus-client
pure-eval
qastle
servicex
stack-data

@eguiraud
Copy link
Contributor Author

This is really more of a problem statement than a PR, so I created #144 to take the place of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants