Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to LLVM with nanobind reverts #19605

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

marbre
Copy link
Member

@marbre marbre commented Jan 5, 2025

Adds nanobind reverts on top of #19600 to allow the macOS build to pass (see #19591).

Adds nanobind reverts on top of #19600.
@marbre
Copy link
Member Author

marbre commented Jan 5, 2025

@marbre marbre marked this pull request as ready for review January 5, 2025 20:56
@marbre marbre requested a review from ScottTodd January 5, 2025 20:56
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: #19591 (this could go in the pr title or description)

@ScottTodd
Copy link
Member

I'd vote to land this then try dropping the revert when we pull in llvm/llvm-project@78f0447

@marbre
Copy link
Member Author

marbre commented Jan 6, 2025

Seems reasonable as just cherry-picking the fix on top of the currently used LLVM version does not resolve the issue, see https://github.com/iree-org/iree/actions/runs/12630160413.

@marbre marbre merged commit e7d4fec into main Jan 6, 2025
41 checks passed
@marbre marbre deleted the users/marbre/nanobind-reverts branch January 6, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants