Reland #18804 #18840
Open
Reland #18804 #18840
+524
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
commented
Oct 18, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/CMakeLists.txt
Outdated
Show resolved
Hide resolved
makslevental
commented
Oct 18, 2024
makslevental
force-pushed
the
users/makslevental/reland-bindings
branch
3 times, most recently
from
e26b754
to
a60fd6c
Compare
makslevental
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss,
antiagainst and
benvanik
as code owners
ScottTodd
approved these changes
Oct 18, 2024
cool. gonna wait for win ci to finish/succeed just to be safe |
This reverts commit df5e5aa. Signed-off-by: Maksim Levental <maksim.levental@gmail.com>
Signed-off-by: Maksim Levental <maksim.levental@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #18804 including main...ScottTodd:iree:ireegpu-api-fixes but also with (currently) a hack for exposing symbols in
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.cpp.TODO
IREEGPUAttrs.cppon windows (alternatively move those C APIs)EDIT: moved C wrappers to
compiler/src/iree/compiler/API/Internal/IREEGPUDialectCAPI.cpp.win CI job: https://github.com/iree-org/iree/actions/runs/11411731188