-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Prefer TileAndFuse pipeline over SIMT pipeline #18793
base: main
Are you sure you want to change the base?
[GPU] Prefer TileAndFuse pipeline over SIMT pipeline #18793
Conversation
678ce49
to
180bc9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we observe the difference using the gemm shapes in https://github.com/nod-ai/iree-kernel-benchmark ?
180bc9a
to
029fd7b
Compare
As I am running it I am realizing that all of but three shapes in the benchmark are multiples of 32 so dont go down these default path, but lets see what I get for those 3. |
@nirvedhmeshram We can add a few more. Do you have some specific shapes you are interested in? |
@kuhar actually on close inspection I do see some shapes that go down SIMT for e.g
However, I am realizing this PR is most likely just an NFC, because TileandFuse just bails on such shapes as it wont find a schedule However I will change that in a follow up, next |
Lets fold this into the subseqent PR? Hard to see what this flag is for. |
Ya that is fine by me, Quinn suggested not to do too much at once, but since this is doing nothing, folding makes sense |
Ah, interesting, could you add this shape to iree-kernel-benchmark? We can tag it as 'corner_case'. |
@jakub that shape is already generated by the benchmark so I was saying no need for adding more cases as the sizes pulled from the models seem to have enough diversity. |
TileandFuse is the modernized pipeline that we would want to use over the older SIMT pipeline when possible.