Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU][DT] Add e2e matmul tests for GPU data tiling #18627

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Max191
Copy link
Contributor

@Max191 Max191 commented Sep 27, 2024

This adds some matmul e2e tests for GPU data tiling on gfx94* chips.

This depends on:
#18626
#18623
#18624
#18625

@bjacob
Copy link
Contributor

bjacob commented Sep 27, 2024

This CMakeLists.txt is autogenerated from BUILD.bazel so update that. Might create opportunity to factor testcases with list comprehensions, see other tests in that file.

@hanhanW
Copy link
Contributor

hanhanW commented Sep 27, 2024

This CMakeLists.txt is autogenerated from BUILD.bazel so update that. Might create opportunity to factor testcases with list comprehensions, see other tests in that file.

This is not true in this directory. The AMDGPU matmul test suites are only available in CMakeLists.txt now. @ScottTodd has been working on some cleanups for e2e tests, but this part is not done yet.

### BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE ###
# To distinguish between CDNA(gfx9) and RDNA3(gfx11)

@ScottTodd
Copy link
Member

This CMakeLists.txt is autogenerated from BUILD.bazel so update that. Might create opportunity to factor testcases with list comprehensions, see other tests in that file.

This is not true in this directory. The AMDGPU matmul test suites are only available in CMakeLists.txt now. @ScottTodd has been working on some cleanups for e2e tests, but this part is not done yet.

### BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE ###
# To distinguish between CDNA(gfx9) and RDNA3(gfx11)

Yeah I have plans to move these matmul tests to https://github.com/iree-org/iree-test-suites/tree/main/linalg_ops/matmul, with some incremental refactoring work on iree-org/iree-test-suites#22. No ETA on the work there - far too backlogged. I haven't looked specifically at testing variants like different GPUs or flags yet.

Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
@Max191 Max191 marked this pull request as ready for review October 3, 2024 15:04
@bjacob
Copy link
Contributor

bjacob commented Oct 3, 2024

@ScottTodd , is iree-test-suites going to be a new submodule in IREE? After the tests get moved there, will they still be run as part of just doing ctest in my IREE build?

@ScottTodd
Copy link
Member

@ScottTodd , is iree-test-suites going to be a new submodule in IREE? After the tests get moved there, will they still be run as part of just doing ctest in my IREE build?

TBD, but likely not a submodule. The separate repository gives us a place to put more files without bloating this repository, so keeping it optional is a design goal.

I have a draft of an integration here: #18291 . Workflows separately git checkout the test suite then follow the steps in the README to build the standalone CMake project (pointing at the already built IREE packages to test) and run the tests. I also tossed around some ideas for a CMake subproject instead of something fully standalone, to preserve the existing ergonomics, but I'm finding that fairly limiting and want to make a clean cut if possible.

@Max191 Max191 merged commit 23b63cd into iree-org:main Oct 7, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants