-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLVMGPU][ROCm] Add I8 MFMA layout support for CDNA2 #18433
[LLVMGPU][ROCm] Add I8 MFMA layout support for CDNA2 #18433
Conversation
53bda5b
to
39ddb7d
Compare
39ddb7d
to
d807e0c
Compare
I considered adding matmul e2e tests for this, but couldnt see a way short of writing a new generate script that will allow us to run the suite for cdna2 without having instrinic mismatch with cdna3. Given that we are testing some models e2e for cdna2, I am okay with this but just wanted to call it out in case reviewers have other idea. |
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUEnums.td
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUEnums.td
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/test/concretize_mma_shapes.mlir
Show resolved
Hide resolved
I'm in the process of migrating the matmul e2e tests to https://github.com/iree-org/iree-test-suites/tree/main/linalg_ops and refactoring to be decoupled from the core IREE CMake project (see iree-org/iree-test-suites#2). Next on my list is refactoring the massive list of |
Note that in the new location, the tests are not using |
These i8 intrinsics are supported by CDNA2 arch so adding them provides better functionality such as fixing iree-org#18406. It is worth noting that, this i8 support is emulated and the CDNA2 hardware does fp16 under the hood for these intrinsics. With this PR we can also support: "sharktank/punet/int8" from the external test suite and hence the xfail on those tests are removed. Fixes: iree-org#18406
These i8 intrinsics are supported by CDNA2 arch so adding them provides better functionality such as fixing iree-org#18406. It is worth noting that, this i8 support is emulated and the CDNA2 hardware does fp16 under the hood for these intrinsics. With this PR we can also support: "sharktank/punet/int8" from the external test suite and hence the xfail on those tests are removed. Fixes: iree-org#18406
These i8 intrinsics are supported by CDNA2 arch so adding them provides better functionality such as fixing #18406. It is worth noting that, this i8 support is emulated and the CDNA2 hardware does fp16 under the hood for these intrinsics.
With this PR we can also support: "sharktank/punet/int8" from the external test suite and hence the xfail on those tests are removed.
Fixes: #18406