Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch more ci.yml jobs to optional based on paths changed. #17923

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Switch more ci.yml jobs to optional based on paths changed. #17923

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78698e2
Switch more ci.yml jobs to optional based on paths changed.
ScottTodd Jul 16, 2024
5dd6eb9
Add jobs to default_postsubmit_only also, add comments + logging.
ScottTodd Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions build_tools/github_actions/configure_ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,22 @@ def contains(cls, val):
]
)

NVGPU_PATHS = [
# Directly related to NVIDIA GPU code generation and execution:
"compiler/src/iree/compiler/Codegen/LLVMGPU/*",
"runtime/src/iree/hal/drivers/cuda/*",
# Common code likely enough to affect code paths unique to NVIDIA GPUs:
"compiler/src/iree/compiler/GlobalOptimization/*",
]

AMDGPU_PATHS = [
# Directly related to AMDGPU code generation and execution:
"compiler/src/iree/compiler/Codegen/LLVMGPU/*",
"runtime/src/iree/hal/drivers/hip/*",
# Common code likely enough to affect code paths unique to AMDGPU:
"compiler/src/iree/compiler/GlobalOptimization/*",
]

# Jobs to run in presumbit if files under the corresponding path see changes.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to change build_test_runtime :: arm64 from ci.yml and Regression Test / test_onnx :: amdgpu_vulkan from pkgci_regression_test.yml, but those jobs are under matrices that can't use

if: contains(fromJson(needs.setup.outputs.enabled-jobs), 'job_name')

At least the pkgci jobs are not blocking PR merges right now.

Definitely want build_test_runtime :: arm64 excluded too. That competes with build_test_all_arm64 for a single runner when LLVM integrate PRs are running 1h+ builds like https://github.com/iree-org/iree/actions/runs/9960816403/job/27520932492.

Strategies: https://stackoverflow.com/questions/65384420/how-do-i-make-a-github-action-matrix-element-conditional

# Each tuple consists of the CI job name and a list of file paths to match.
# The file paths should be specified using Unix shell-style wildcards.
Expand All @@ -147,6 +163,14 @@ def contains(cls, val):
# "build_test_all_windows",
# ["*win32*", "*windows*", "*msvc*", "runtime/src/iree/builtins/ukernel/*"],
# ),
#
# The runners with GPUs for these jobs can be unstable or in short supply,
# so limit jobs to only code paths most likely to affect the tests.
("test_nvidia_gpu", NVGPU_PATHS),
# ("test_nvidia_a100", NVGPU_PATHS),
("test_amd_mi250", AMDGPU_PATHS),
("test_amd_mi300", AMDGPU_PATHS),
# ("test_amd_w7900", AMDGPU_PATHS),
]

# Default presets enabled in CI.
Expand Down
Loading