[NFC] Update from deprecated llvm::Optional #12734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpienaar
requested review from
hanhanW,
MaheshRavishankar,
rsuderman,
stellaraccident,
antiagainst,
ThomasRaoux,
dcaballe and
benvanik
as code owners
GMNGeoffrey
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Can you expand the description. Useful info:
- Links to the explanation of the deprecation
- How you generated this change
- The support status of std::optional. Looks like it's C++17, which we've already bumped to, I think, but I do see some references to C++14 still, e.g. https://github.com/openxla/iree/blob/c6b6aba2e5023c58e2c9fa1ec6607367e23b3022/runtime/src/iree/vm/native_module_packing.h#L21
|
Done, my scripting wasn't the best here so I did a few rounds with manual editing for too broad regex'es. |
GMNGeoffrey
approved these changes
Mar 23, 2023
dcaballe
approved these changes
Mar 23, 2023
Switch to std::optional which is currently an alias.
MaheshRavishankar
approved these changes
Mar 23, 2023
Merged
jpienaar
added a commit
that referenced
this pull request
May 1, 2023
This is being deprecated in LLVM (https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716). This change was _mostly_ mechanically done via find/ripgrep/sed, with exception of TableGen files which were more complicated (Optional in DAG vs member function or C++ type usage and required checking manually).
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
This is being deprecated in LLVM (https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716). This change was _mostly_ mechanically done via find/ripgrep/sed, with exception of TableGen files which were more complicated (Optional in DAG vs member function or C++ type usage and required checking manually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being deprecated in LLVM (https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716). This change was mostly mechanically done via find/ripgrep/sed, with exception of TableGen files which were more complicated (Optional in DAG vs member function or C++ type usage and required checking manually).