-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable /Zi
when using ccache on Windows/MSVC.
#11841
Conversation
message(STATUS "Replacing /Zi with /Z7 since ccache is in use and does not support /Zi") | ||
# https://learn.microsoft.com/en-us/cpp/build/reference/z7-zi-zi-debug-information-format | ||
string(REPLACE "/Zi" "/Z7" CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG}") | ||
string(REPLACE "/Zi" "/Z7" CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG}") | ||
string(REPLACE "/Zi" "/Z7" CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO}") | ||
string(REPLACE "/Zi" "/Z7" CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this will affect downstream users too. Not really a fan of when projects modify global flags, but I think this is niche enough...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's conditional on ccache usage and anyone using ccache would need the same thing it seems ok - may still conflict with a user's similar hacks but probably worth waiting for that to be an issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this!
One step towards enabling [ccache](https://ccache.dev/) on our Windows CI, but there are a few details to still work through: #11009 (comment). On my machine, I see these results (sample size 1): > clean build (no cache): 528 seconds > ``` > λ ccache --show-stats > Cacheable calls: 3942 / 3943 (99.97%) > Hits: 2 / 3942 ( 0.05%) > Direct: 0 / 2 ( 0.00%) > Preprocessed: 2 / 2 (100.0%) > Misses: 3940 / 3942 (99.95%) > Uncacheable calls: 1 / 3943 ( 0.03%) > Local storage: > Cache size (GB): 2.21 / 5.00 (44.21%) > Cleanups: 16 > ``` > clean build (with cache): 96 seconds > ``` > λ ccache --show-stats > Cacheable calls: 3942 / 3943 (99.97%) > Hits: 3939 / 3942 (99.92%) > Direct: 3939 / 3939 (100.0%) > Preprocessed: 0 / 3939 ( 0.00%) > Misses: 3 / 3942 ( 0.08%) > Uncacheable calls: 1 / 3943 ( 0.03%) > Local storage: > Cache size (GB): 2.21 / 5.00 (44.23%) > ``` My only changes to enable ccache were: * Download ccache.exe and put it on my `PATH` * Configure CMake with `-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache` (added to `"cmake.configureArgs": [ ... ]` in VSCode settings)
One step towards enabling ccache on our Windows CI, but there are a few details to still work through: #11009 (comment).
On my machine, I see these results (sample size 1):
My only changes to enable ccache were:
PATH
-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache
(added to"cmake.configureArgs": [ ... ]
in VSCode settings)