-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit Breaks Llama3.1_405b_tp8 Compilation #19833
Labels
bug 🐞
Something isn't working
Comments
I'll try to get the failing dispatch, the commit seems to be causing the compiler to go down a bad codegen path. Do we need to revert until it's fixed? |
This was referenced Jan 28, 2025
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this issue
Feb 4, 2025
…#19835) Reverts iree-org#19828 Fixes iree-org#19833 Signed-off-by: Hyunsung Lee <ita9naiwa@gmail.com>
IanWood1
added a commit
that referenced
this issue
Feb 12, 2025
Reland the changes to fold attention ops with broadcasts with a small tweak to `AttentionOpDetail` so that the batch dimensions are properly computed when an operand is broadcasted. Original PR #19828 Revert PR #19835 Issue causing revert #19833 --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Compilation was broken for
Llama3.1_405b_tp8
, with the following error message:Bisecting points to 4b0ca34
Steps to reproduce your issue
iree-compile
:iree-compile 405b_instruct_fp16.mlir -o 405b_artifacts/tp8/llama_1_28.vmfb --iree-hal-target-device=hip[0] --iree-hal-target-device=hip[1] --iree-hal-target-device=hip[2] --iree-hal-target-device=hip[3] --iree-hal-target-device=hip[4] --iree-hal-target-device=hip[5] --iree-hal-target-device=hip[6] --iree-hal-target-device=hip[7] --iree-hip-target=gfx942 --iree-dispatch-creation-enable-aggressive-fusion=true --iree-global-opt-propagate-transposes=true --iree-opt-aggressively-propagate-transposes=true --iree-opt-data-tiling=false --iree-preprocessing-pass-pipeline='builtin.module(util.func(iree-preprocessing-generalize-linalg-matmul-experimental))' --iree-hal-indirect-command-buffers=true --iree-stream-resource-memory-model=discrete --iree-hal-memoization=true --iree-opt-strip-assertions
What component(s) does this issue relate to?
Compiler
Version information
22b34b5
Additional context
No response
The text was updated successfully, but these errors were encountered: