-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrays do not match in python/vm_types_test:test_variant_list_buffers on Windows #11080
Comments
This doesn't seem to be failing at head, was this fixed or still an issue? |
The test is disabled in the script our CI runs: iree/build_tools/cmake/ctest_all.sh Lines 87 to 88 in 533c246
I haven't verified if any tests in that list were fixed on their own. |
Hey @ScottTodd checking on this as it's listed as P1. Should we downgrade or add an owner? Or is it fixed? |
Likely still an issue, and pretty scary that Python bindings for central functionality are failing some tests on Windows, so P1 is appropriate. |
Yep, still an issue. The Test code here: https://github.com/openxla/iree/blob/84852a56e051e30960d3facbf050defac06590fd/runtime/bindings/python/tests/vm_types_test.py#L49-L72 |
Narrowing this down, I'm suspecting pybind behavior is different on Windows (maybe pybind/pybind11#1908 ?). printf debugging Windows:
and Linux:
(numpy.int64 is mapping to the int32 dtyle and not int64) |
I'm testing with and without |
Ahhh this is in the code I was just reviewing (#12872) Per that pybind issue, |
Fixes #11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code `l`, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string in `numpy.sctypeDict.keys()`, [shown in this gist](https://gist.github.com/ScottTodd/ec1f7906e9c644eb47f74280d6c26229)). Relates to #12872
Fixes #11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code `l`, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string in `numpy.sctypeDict.keys()`, [shown in this gist](https://gist.github.com/ScottTodd/ec1f7906e9c644eb47f74280d6c26229)). Relates to #12872
Fixes iree-org#11080. The int64 and uint64 test cases here were failing on Windows as the element type mapping was routing via the code `l`, which is a "C long int" - not an explicitly 64 bit type. This changes the mapping to always use the explicit "type strings" (any string in `numpy.sctypeDict.keys()`, [shown in this gist](https://gist.github.com/ScottTodd/ec1f7906e9c644eb47f74280d6c26229)). Relates to iree-org#12872
Spotted when adding a Windows CI build: https://github.com/iree-org/iree/actions/runs/3414442364/jobs/5682427788, and then reproduced locally.
Full logs:
Test code:
iree/runtime/bindings/python/tests/vm_types_test.py
Lines 49 to 72 in 75636a9
The text was updated successfully, but these errors were encountered: