address comments

Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
iree-org · Sep 20, 2024 · e5160bf · e5160bf
1 parent 0a00cfd
commit e5160bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/compiler/src/iree/compiler/Codegen/Common/DecomposePackUnPackOps.cpp b/compiler/src/iree/compiler/Codegen/Common/DecomposePackUnPackOps.cpp
@@ -104,7 +104,7 @@ struct DecomposePackUnPackOpsPass final
   void runOnOperation() override;
 
 private:
-  std::optional<PackUnPackControlFn> controlFn = std::nullopt;
+  std::optional<PackUnPackControlFn> controlFn;
 };
 
 } // namespace

diff --git a/compiler/src/iree/compiler/Codegen/Common/Passes.h b/compiler/src/iree/compiler/Codegen/Common/Passes.h
@@ -68,11 +68,12 @@ std::unique_ptr<InterfacePass<FunctionOpInterface>>
 createConvolutionToIGEMMPass(ConfigFn configFn);
 
 using PackUnPackControlFn = std::function<LogicalResult(Operation *)>;
-// Pass to decompose pack and unpack ops into pad/extract_slice and reshape ops.
-// If specified, `controlFn` controls which ops get decomposed. The `controlFn`
-// should be used with `useOnlyReshapes` set to true.
-// TODO(Max191): Add a controlFn upstream for `GeneralizeOuterUnitDim*` patterns
-// and remove the need to have `useOnlyReshapes = true` when using `controlFn`.
+/// Pass to decompose pack and unpack ops into pad/extract_slice and reshape
+/// ops. If specified, `controlFn` controls which ops get decomposed. The
+/// `controlFn` should be used with `useOnlyReshapes` set to true.
+/// TODO(Max191): Add a controlFn upstream for `GeneralizeOuterUnitDim*`
+/// patterns and remove the need to have `useOnlyReshapes = true` when using
+/// `controlFn`.
 std::unique_ptr<InterfacePass<FunctionOpInterface>>
 createDecomposePackUnPackOpsPass(bool tileOuterToOne, bool useOnlyReshapes,
                                  std::optional<PackUnPackControlFn> controlFn);