Skip to content

Commit

Permalink
Update onnx package version minimum to 1.16.0. (#17504)
Browse files Browse the repository at this point in the history
As discovered on
#17476 (comment), this
is needed to avoid an error running `iree-import-onnx` on certain test
files:

> onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version
10 is higher than the checker's (9).

If we care about supporting older onnx package versions, we could add
some fallback code to `iree-import-onnx`.

We may also want to update the version used in torch-mlir?
https://github.com/llvm/torch-mlir/blob/e0a5adb1db38b0072c44b87570bc530eb3b324ad/setup.py#L264
  • Loading branch information
ScottTodd authored May 28, 2024
1 parent a6a56a9 commit 29e70ab
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ jobs:
pip install --upgrade pip
# Pre-fetch optional deps that iree-compiler needs (but we constrain that
# to not consult a package index).
pip install onnx>=1.15.0
pip install onnx>=1.16.0
pip install --no-index -f $PWD -v iree-compiler[onnx]
echo "Testing default compiler:"
python -m iree.compiler._package_test
Expand Down
2 changes: 1 addition & 1 deletion compiler/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def find_git_submodule_revision(submodule_path):
],
extras_require={
"onnx": [
"onnx>=1.15.0",
"onnx>=1.16.0",
],
},
)

0 comments on commit 29e70ab

Please sign in to comment.