Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate MLIR files for matmul tests. #14

Closed
wants to merge 1 commit into from

Conversation

ScottTodd
Copy link
Member

Progress on #2

This runs the generator script using some of the option combinations found in the CMakeLists.txt so we can look at what it generates. This does not set --transpose_rhs or --compilation_info yet.

Some observations:

  • I'm not sure if grouping by "shape" in the source files will continue to be useful. I'd rather split these out into one file per test case. We can add sharding and batching up a level in the test runner. I guess this does let us feed multiple modules in to the compiler at the same time, at least.
  • We can decouple compiler flags, test tags, CPU features, runtime flags, and similar properties from these generated test files.
  • I would like to also decouple the compilation info parameter - that feels like a meta property that should come through compilation flags, not be part of the test sources.

@ScottTodd
Copy link
Member Author

Closing in favor of #22

@ScottTodd ScottTodd closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant