fgwrite: Fix definition of card size #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `card` string is used in a `getcwd(card, SZ_PATHNAME)` call. The man page or getcwd says however: > char *getcwd(char *buf, size_t size); > [...] > The size argument is the size in bytes of the character array pointed > to by the buf argument. `SZ_PATHNAME` is set to 511; however `card` had only 256 chars. With hardening enabled, this lead to a segmentation fault. This patch just increases the size of `card` to the necessary value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cardstring is used in agetcwd(card, SZ_PATHNAME)call. The man page of getcwd (3) says:SZ_PATHNAMEis set to 511; howevercardhad only 256 chars. With hardening enabled, this results in a segmentation fault on Debian.This patch just increases the size of
cardto the necessary value.