Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for secret connection to tendermint v0.33.x. #57

Closed
wants to merge 2 commits into from
Closed

Support for secret connection to tendermint v0.33.x. #57

wants to merge 2 commits into from

Conversation

shiki-tak
Copy link

Support for tendermint v0.33.x to resolve a cryptographic error that was a problem with #24 .

  • Cause
    • The way to p2p handshake when updating from tendermint v0.32.x to v0.33.x has been changed.
    • The transcript was introduced in handshake.
  • Correspond
    • Introduce to transcript using Merlin

Cargo.toml Outdated
once_cell = "1.3"
orion = { version = "0.15.1", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like you're using this for anything? Also the primitives it provides should already be available

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I removed it.

@zmanian
Copy link
Contributor

zmanian commented Jun 6, 2020

Thanks for catching the original bug @shiki-tak

Opened #58 that supports both the v0.33 and legacy handshakes.

@zmanian zmanian closed this Jun 6, 2020
@njmurarka njmurarka mentioned this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants