[init_cell] allow celltoolbar preset to load from metadata setting #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using Jupyter.notebook.config
as it's more efficient than parsing the string representation for require calls
also separate the notebook loaded callback from the promise structure
in order that the preset will be activated, if the appropriate notebook metadata key is set. Fixes ipython-contrib#910.
|
The conda builds are currently error-ing on travis, as a result of a failure to install conda-build, which is occurring for reasons I don't yet understand. I'm going to go ahead and merge this anyway |
This was referenced Mar 16, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.