-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Only execute codefolding preprocessor when requested #794
Conversation
@jcb91 : I would like to move the |
Sure, seems like a sensible move. I think we even already have an internals file :) |
Is there any deeper meaning why |
No, I just kept to markdown for anything that didn't require rst-only |
============================ | ||
|
||
The nbextensions are stored each as a separate subdirectory of | ||
`src/jupyter_contrib_nbextensions/nbextensions` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in rst, inline literals may need two backticks? I believe the notebook repo has somehow enabled use of single backticks, but I'm not sure how. The only reference to single backticks that I can find is this, which seems to suggest that by default, single backticks have no special meaning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the single backticks give the default role, which is configurable. Perhaps we should add a
default_role = 'code'
to conf.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Yes, I think we should set the default role.
@jcb91 Any idea why one test fails ? I don't see how my changes would affect it. |
It's the 4.x notebook branch, and it's just failing to build notebook,
before even running our tests, so it's not really anything to do with your
changes, I think. Looks fine to merge to me!
…On 27 Nov 2016 09:01, "Juergen Hasch" ***@***.***> wrote:
@jcb91 <https://github.com/jcb91> Any idea why one test fails ? I don't
see how my changes would affect it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#794 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFXq9kLSs6nEfobqTXbEy6g5Yv7vXdgvks5rCUbygaJpZM4KyYRA>
.
|
Addresses #792