Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/json session serializer and Django 5 support #35

Merged
merged 12 commits into from
Jul 27, 2024

Conversation

mikemanger
Copy link

@mikemanger mikemanger commented Jul 25, 2024

This is a rebase of #20. The changes are:

  • Adds support for Django's default JSONSerializer
  • Adds some constants for hardcoded strings
  • Support for Django 5 and Python 3.12 to fix Django 5 support #34

As noted in the original PR after changing the serializer you need to clear your sessions with python manage.py clearsessions.

@mikemanger mikemanger marked this pull request as ready for review July 25, 2024 12:24
@mikemanger
Copy link
Author

mikemanger commented Jul 25, 2024

One thing I'm confused about is that there are some scary deprecation warnings in 4.1 and 4.2 about some of the templates:

password_policies/tests/test_views.py::PasswordChangeViewsTestCase::test_password_change_confirm
RemovedInDjango50Warning: The "default.html" templates for forms and formsets will be removed. These were proxies to the equivalent "table.html" templates, but the new "div.html" templates will be the default from Django 5.0. Transitional renderers are provided to allow you to opt-in to the new output style now. See https://docs.djangoproject.com/en/4.2/releases/4.1/ for more details

I am struggling to see what is causing this as we override the templates anyway.🤔

EDIT: this was happening before the patch but it might still be relevant for 5.0 support.

@mpasternak mpasternak merged commit 020d218 into iplweb:develop Jul 27, 2024
5 checks passed
@mpasternak
Copy link
Member

Commited, thanks! This is a lot of work, thank you!

@mikemanger mikemanger deleted the feature/json-session-serializer branch October 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 5 support
3 participants