Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trustless gateway: document probing path (identity cid) #491

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hsanjuan
Copy link
Contributor

Add section about status codes.

Add section about Retry-After.

Add section about status codes.

Add section about Retry-After.
@hsanjuan hsanjuan requested a review from lidel as a code owner February 12, 2025 15:41
@hsanjuan hsanjuan self-assigned this Feb 12, 2025
Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍🏻

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Quick feedback inline.
In the long term, we need to figure out how to avoid duplicating content different way, but for now we try to reuse https://specs.ipfs.tech/http-gateways/path-gateway/ and link to it where possible.

@hsanjuan hsanjuan requested a review from lidel February 19, 2025 11:48
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second pass, lgtm, but some MUSTs and phrasing should be relaxed to match reality (details/suggestions inline)

@lidel lidel changed the title trustless gateway spec: add probing path (identity cid). trustless gateway: document probing path (identity cid) Feb 19, 2025
hsanjuan and others added 2 commits February 20, 2025 10:21
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@hsanjuan hsanjuan requested a review from lidel February 20, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants