Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter #11 #44

Closed
wants to merge 9 commits into from
Closed

Newsletter #11 #44

wants to merge 9 commits into from

Conversation

RichardLitt
Copy link
Member

@RichardLitt RichardLitt commented May 16, 2016

Renamed Weekly to Newsletter.
Added in all comments from #41.

Needs:

  • Look for and add press.
  • Add contributors (cc @eminence)
  • @noffle Can you write something better about twitter-resolver?
  • Review

@hackergrrl
Copy link
Contributor

hackergrrl commented May 17, 2016

common-readme: I think it might make sense to drop this from the newsletter? It's not specific to IPFS and I think it's confusing to list both projects here. If you want to link to it within your repo though as a mention that'd be cool.

@jbenet
Copy link
Member

jbenet commented May 17, 2016

What period of time does this weekly cover? I will mention various things once i know

@RichardLitt
Copy link
Member Author

@jbenet The last couple of weeks; anything since April 25th.

@eminence
Copy link
Contributor

eminence commented May 17, 2016

Added Contributors for this period (2015-04-25T00:00:01 to 2015-05-16T00:00:01)

Note that I just pushed a small change to get_commits.py that will now use the github API to get the commit authors github login/name. See 4416c5d

Edit: April 2015 was most certainly not the correct data range to use! This has now been fixed, thanks @dignifiedquire . Contributors for this period (2016-04-25T00:00:01 to 2016-05-16T00:00:01)

* [@wking](https://github.com/wking) (W. Trevor King)
* [@bmcorser](https://github.com/bmcorser) (bmcorser)
* [@krl](https://github.com/krl) (kristoffer)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list seems very incomplete. @nginnever @diasdavid and me (@dignifiedquire) have pushed a decent amout of code in the past weeks. Also krl is mentioned twice in this list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yes. Where are you very important people. Let me look. Thanks for paying attention!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my goodness. i did a terrible thing. when I ran the tool, I used 2015, not 2016! A fix is incoming!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D that would explain this list

@dignifiedquire
Copy link
Member

thanks @eminence!

@RichardLitt
Copy link
Member Author

Got another bug in name-your-contributors -- not sure what it is, don't have the time to debug it right now. Need to go through and update it before the list at the bottom reflects more than the committers only.

RichardLitt added a commit that referenced this pull request Jul 19, 2016
@RichardLitt RichardLitt mentioned this pull request Jul 19, 2016
@RichardLitt
Copy link
Member Author

@eminence I want to close this newsletter and start fresh with a new one. Can you pull out your commits from this PR and put them in their own?

@eminence
Copy link
Contributor

I had 3 commits in this PR, 2 of them related to the newsletter itself, and 1 was a tools change to get_commits.py. That tools change (4416c5d) is already in the master branch, so it's now safe to delete this PR

@RichardLitt
Copy link
Member Author

Thanks @eminence. Rebased.

This newsletter is very old at this point, and the next one should be started anew. I am going to close this and not try to send a retrospective newsletter for this two week session, but rather for the two months or so since the last one.

jennwrites added a commit that referenced this pull request Jun 10, 2019
@jennwrites jennwrites deleted the feature/newsletter-11 branch October 29, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants