Update config.md #9921
Merged
Update config.md #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Jun 7, 2023
Jorropo
requested changes
Jun 7, 2023
docs/config.md
Outdated
Comment on lines
1922
to
1924
| [TCP](https://en.wikipedia.org/wiki/Transmission_Control_Protocol) doesn't | ||
| directly support encryption and/or multiplexing, so libp2p will layer a security | ||
| & multiplexing transport over it. |
There was a problem hiding this comment.
Suggested change
| [TCP](https://en.wikipedia.org/wiki/Transmission_Control_Protocol) doesn't | |
| directly support encryption and/or multiplexing, so libp2p will layer a security | |
| & multiplexing transport over it. | |
| [TCP](https://en.wikipedia.org/wiki/Transmission_Control_Protocol) is a simple | |
| and well deployed transport, it should be inter-compatible with most | |
| implementations and network configurations. | |
| TCP doesn't directly support encryption and/or multiplexing, so libp2p will | |
| layer a security & multiplexing transport over it. |
There was a problem hiding this comment.
"Widely deployed" instead of "well deployed". "should be compatible" instead of "inter-compatible".
besides that, looks good.
There was a problem hiding this comment.
👍 will you commit then I merge ?
There was a problem hiding this comment.
I meant well deployed as:
Should be resistant-ish to middle boxes fucking up things they don't know about.
(because they most likely know about TCP)
Yours sounds better.
Jorropo
reviewed
Jun 7, 2023
docs/config.md
Outdated
| built-in encryption and multiplexing. The primary benefits over TCP are: | ||
| [QUIC](https://en.wikipedia.org/wiki/QUIC) is the most widely used transport by | ||
| Kubo nodes. It is a UDP-based transport with built-in encryption and | ||
| multiplexing. The primary benefits over TCP are: | ||
|
|
||
| 1. It doesn't require a file descriptor per connection, easing the load on the OS. | ||
| 2. It currently takes 2 round trips to establish a connection (our TCP transport |
There was a problem hiding this comment.
Also I would add HOL to that list.
There was a problem hiding this comment.
Also the 2 rounds trips is wrong. Just 1.
Jorropo
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per data collected by @marten-seemann's Kubo node.
