docs: note log tail is broken #9383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Nov 2, 2022
core/commands/log.go
Outdated
| @@ -34,7 +34,8 @@ system (not just for the daemon logs, but all commands): | |||
| Subcommands: map[string]*cmds.Command{ | |||
| "level": logLevelCmd, | |||
| "ls": logLsCmd, | |||
| "tail": logTailCmd, | |||
| // FIXME: Re-enable `ipfs log tail` command. Tracked in https://github.com/ipfs/kubo/issues/9245 | |||
| // "tail": logTailCmd, | |||
There was a problem hiding this comment.
linting is failing because logTailCmd is defined and unused, we can remove the function, or leave it and just add messaging.. lmk
but keep the messaging with the link back to the broken issue
lidel
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the proper fix @Jorropo or other maintainers had in mind was, but disabling
ipfs log tailuntil #9245 is resolved is one path. Just opening this to push the short conversation @Jorropo and I had on slack forward.