docs: ipfs-http-client -> kubo-rpc-client #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigLep
reviewed
Oct 5, 2022
Co-authored-by: Steve Loeppky <stvn@loeppky.com>
|
@SgtPooki : I see I'm a requested reviewer. I don't know if I can get to it this week. Lets incorporate Lidel's feedback and then I think we'll call that good enough. |
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
|
@lidel ping |
SgtPooki
dismissed
lidel’s stale review
addressed comments. need another review
lidel
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: ipfs/js-kubo-rpc-client#35
Parent issue: ipfs/js-kubo-rpc-client#6
Originating issue: #9125
This PR is intended to update the docs in ipfs/kubo so that users will be pointed to
kubo-rpc-clientinstead ofipfs-http-clientwhen using Javascript/TypeScript to talk to Kubo.I noticed a lack in discussion about programmatic/api usage, so I modified more than may be expected, but I think it should be a significant improvement.
Keeping the list of http-clients up to date now involves only updating a single file in this repo. LMK if this is not desireable.
For other docs updates, follow ipfs/js-kubo-rpc-client#6
fixes ipfs/js-kubo-rpc-client#35
Things for reviewers to check: