[testing] update datastore to use contexts with sharness failure #8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making deprecation notice match the go-ipfs-config key
Applies changes from ipfs/go-ipfs-config@c46fe1b
Clarified docs based on #8522 (comment) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
this moves relay "user" flag before the "service" to align better with new docs in effort to limit the number of people that mistake the two. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This switches to config that supports setting and reading Internal.Libp2pForceReachability OptionalString flag License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
does not cause issue locally, let's see how behaves on CI
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
- applies fix from go-ipfs-config which removes null when default - escapes JSON string when passed in sharness script
* test: add tests for automatic sharding and unsharding * refactor: changed some naming in the sharding sharness tests to make more sense Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
This is for testing the libp2p release, since the context changes are not plumbed all the way through.
…datastore # Conflicts: # core/coreapi/test/path_test.go # core/node/groups.go # go.mod # go.sum
aschmahmann
changed the title
|
Not needed anymore. Closed #8563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8563 has a lot going on already, and there's a sharness failure we're only really seeing in CI. Using this PR to debug