feat: multibase transcode command #8403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid `multibase decode | multibase encode`
This comment has been minimized.
This comment has been minimized.
lidel
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Thank you @andey-robins! LGTM. ❤️
@aschmahmann ready for your final review and merge
Discussed during go-ipfs sync today – should be safe to include in 0.10.0-rc2, merging.
BigLep
changed the title
lidel
changed the title
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add a transcoder command to multibase In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid `multibase decode | multibase encode` * Example code needed go mod tidy Co-authored-by: gammazero <gammazero@users.noreply.github.com> (cherry picked from commit c891109)
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add a transcoder command to multibase In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid `multibase decode | multibase encode` * Example code needed go mod tidy Co-authored-by: gammazero <gammazero@users.noreply.github.com> (cherry picked from commit c891109)
aschmahmann
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add a transcoder command to multibase In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid `multibase decode | multibase encode` * Example code needed go mod tidy Co-authored-by: gammazero <gammazero@users.noreply.github.com> (cherry picked from commit c891109)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to more easily facilitate the conversion between multibase formats, include a transcode command to avoid
multibase decode | multibase encodeCloses #8336
Related to PR #8180, adds in some of the functionality discussed as desired, but not required for that PR.
(This is my first PR, and I've read through the Contribution Guidelines for the go-ipfs projects and the ipfs/community guidelines as well, but if I've missed something please just let me know!)