feat: improve mkreleaslog #8290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Jul 21, 2021
Stebalien
commented
- Allow matching the entire module instead of just github orgs/usernames.
- Allow excluding some modules.
- Ignore files using a github pathspec and apply the same ignore patterns to the "contributors" section.
1. Allow matching the entire module instead of just github orgs/usernames. 2. Allow excluding some modules. 3. Ignore files using a github pathspec and apply the same ignore patterns to the "contributors" section.
aschmahmann
reviewed
Jul 21, 2021
bin/mkreleaselog
Outdated
Comment on lines
151
to
152
| # Check to see if this commit includes any non-ignored files. | ||
| # Use jq instead of grep so we get PCRE regexes. |
There was a problem hiding this comment.
Maybe I'm just being bad at bash, but where's the jq here?
There was a problem hiding this comment.
Ah, that use of jq was stillborn. Let me fix the comment.
aschmahmann
reviewed
Jul 21, 2021
I had _thought_ pathspecs needed to start with / to only match the root, but apparently not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.