Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrade mimetype dependency #8229

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix: downgrade mimetype dependency #8229

merged 1 commit into from
Jun 30, 2021

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Jun 30, 2021 •
edited
Loading

Updating this dependency caused some CIDs like bafkqaaa which previously were shown on gateways (in bafkqaaa's case as an empty page) to error due to inability to find the mimetype. This seems to be fixed in the latest release, but that requires some investigation.

@aschmahmann aschmahmann requested a review from lidel June 30, 2021 16:05
@aschmahmann aschmahmann mentioned this pull request Jun 30, 2021
Closed
2 tasks
lidel
lidel approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this PR fixes the problem (#8230).
It makes tests from #8232 pass.

@aschmahmann aschmahmann merged commit ffe7578 into master Jun 30, 2021
@lidel lidel deleted the fix/downgrade-mimetype-dep branch October 13, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschmahmann @lidel