Enumerate available encodings for dag get #8171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
DO NOT MERGE DO NOT REVIEW
License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
This should fix a sharness test failure which we fixed by changing PBNode decoding to allow any field order.
willscott
force-pushed
the
feat/dag-put-ipld-prime
branch
from
49c78d7 to
cdde999
Compare
masih
added a commit
that referenced
this pull request
Jul 20, 2021
Write a `sharness` test that expects failure documenting the issue raised in #3503. The issue may get resolved in the refactoring of `ipfs dag get` command to support go-ipld-prime (e.g. #8171). For now add a `sharness` test that expects failure. We will then flip the expectation in the success in the rewriting PR to check if #3503 gets resolved. Relates to: - #3503
rvagg
force-pushed
the
feat/dag-put-ipld-prime
branch
from
42155c4 to
6522df1
Compare
aschmahmann
force-pushed
the
feat/ipld-in-ipfs
branch
from
9b6af8e to
7a975b0
Compare
lidel
reviewed
Aug 16, 2021
There was a problem hiding this comment.
UX sidenote: fysa it is possible to enumerate all codecs in ipfs cid codecs --numeric, I think it would be useful to add something like --supported there, so user knows which codecs can be processed by the node and the ipfs dag get|put helptext for input-enc and format could refer to ipfs cid codecs --supported for list of available options.
|
@aschmahmann What's the status of this PR? Asking in relation to the description in #8471. |
|
I suspect this PR can be closed (it's certainty very out of date). I'd refer @lidel's solution above (#8171 (review)) as probably the correct way to do this. @willscott if you feel otherwise please reopen the PR and remind me what I'm missing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, i believe, is the basic sketch of what would be needed to late bind connection of the
dag getsubcommand.It attempts to optimistically load plugins before help, which will work except for some edge cases (like that a config is passed in on stdin that sets which directory to find plugins in).
It then gets the root command via method to provide a way for the commands package to allow the dag package to do finalization of its command struct and attach enumerable encoders.
Thoughts on if this makes sense or alternative constructions, @aschmahmann ?