experimental provider system #8070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/experimental-provider-system
branch
from
3fbb6aa to
105b730
Compare
aschmahmann
force-pushed
the
feat/experimental-provider-system
branch
from
acbd82f to
dbdee7f
Compare
aschmahmann
force-pushed
the
feat/experimental-dht-client
branch
2 times, most recently
from
3556ad2 to
476444c
Compare
aschmahmann
force-pushed
the
feat/experimental-provider-system
branch
from
dbdee7f to
c5a49d2
Compare
aschmahmann
force-pushed
the
feat/experimental-provider-system
branch
from
c5a49d2 to
35c25f1
Compare
lidel
approved these changes
May 13, 2021
| ShortDescription: ` | ||
| Returns statistics about the content the node is advertising. | ||
|
|
||
| This interface is not stable and may change from release to release. |
There was a problem hiding this comment.
💭 (not related to this PR, but in general) would be cool if go-ipfs-cmds had a flag to indicate "experimental" and "deprecated" hint, so markdown generated by https://github.com/ipfs/http-api-docs could reflect that in some visual way.
Perhaps a simple boolean flag would do? How could I kick this off? PR against go-ipfs-cmds?
There was a problem hiding this comment.
Not sure, probably? Maybe start an issue in go-ipfs for tracking and collecting feedback before starting on the PR.
gammazero
approved these changes
May 13, 2021
aschmahmann
force-pushed
the
feat/experimental-dht-client
branch
2 times, most recently
from
d9d6ba3 to
2fd55d1
Compare
The batched provider system is enabled when the experimental AcceleratedDHTClient is enabled There is also an `ipfs stats provide` command which gives stats about the providing/reproviding system when the batched provider system is enabled
…T Client and batched providing system
aschmahmann
force-pushed
the
feat/experimental-provider-system
branch
from
e226399 to
acd4683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an experimental provider system that makes use of the experimental dht client.
Depends on ipfs/go-ipfs-provider#34, links to #8061
The point of this system is to be able to quickly provide by being sympathetic to how Kademlia works. For the time being it tries to get records into the DHT very quickly at the expense of having a spike in resource usage during that time.
It also comes with a few extras that have been added for sanity purposes during testing/evaluation and that may be useful in production including: