ipfs add -w #709
Merged
ipfs add -w #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait for #710 (and rebase on top of master once it merges) |
| @@ -64,6 +65,22 @@ func AddR(n *core.IpfsNode, root string) (key string, err error) { | |||
| return k.String(), nil | |||
| } | |||
|
|
|||
| // AddWrapped adds data from a reader, and wraps it with a directory object | |||
| // to preserve the filename. | |||
| func AddWrapped(n *core.IpfsNode, r io.Reader, filename string) (string, *merkledag.Node, error) { | |||
There was a problem hiding this comment.
is filename the name of the directory?
There was a problem hiding this comment.
Could you document the return values?
|
#710 merged now. |
|
…ped directory (to preserve filename in path)
|
RFM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
-wor--wrap-with-directoryflag toipfs add, so that files can have their name preserved. For example,ipfs add -w file.txtshould outputadded <hash>/file.txt file.txt.