Add sessions when fetching MerkleDAG in LS #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
force-pushed
the
chores/add-sessions-to-ls-command-4908
branch
2 times, most recently
from
74e4330
to
b83daf7
Compare
Uses sessions when fetching MerkleDAG License: MIT Signed-off-by: hannahhoward <hannah@hannahhoward.net>
hannahhoward
force-pushed
the
chores/add-sessions-to-ls-command-4908
branch
from
b83daf7
to
47f3c40
Compare
|
Looks like a completely reasonable improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Improve bandwidth usage for LS by adding Sessions
Implementation
This is simply the code by @whyrusleeping referenced here -- https://github.com/ipfs/go-ipfs/compare/feat/ls-session?expand=1 - in #4979 . Regardless of the ultimate solution we end up using for HAMT directory speedup (#4908 ), is there any reason this can't be merged now? This seems like a tangible improvement, if not in speed at least in bandwidth usage