Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cid-fmt binary in test/bin. #5297

Merged
merged 1 commit into from
Jul 29, 2018
Merged

Include cid-fmt binary in test/bin. #5297

merged 1 commit into from
Jul 29, 2018

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Jul 28, 2018

This utility should allow us to eliminate many of the hard-coded hashes we have in the sharness tests.

For example to test that we are indeed using raw leaves we can just use

  HASH=$(ipfs add -q --raw-leaves smallfile) &&
  test "$(cid-fmt %c $HASH)" = "raw"

without having to test against a specific hash.

Right now I am using it in #5285.

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina requested a review from Kubuxu as a code owner July 28, 2018 06:31
@ghost ghost assigned kevina Jul 28, 2018
@ghost ghost added the status/in-progress In progress label Jul 28, 2018
@whyrusleeping whyrusleeping merged commit c4f5a6d into master Jul 29, 2018
@whyrusleeping whyrusleeping deleted the kevina/cid-fmt branch July 29, 2018 05:27
@ghost ghost removed the status/in-progress In progress label Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants