Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always try to read ahead by at least 5 blocks in the PBDagReader #5162

Merged
merged 5 commits into from
Jul 17, 2018
Merged

always try to read ahead by at least 5 blocks in the PBDagReader #5162

merged 5 commits into from
Jul 17, 2018

Commits on Jun 27, 2018

  1. use copy instead of looping 

    License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    12719a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. better handle context cancellations in the PBDagReader 

    Good: If a previous read is canceled, we cancel the preloads that the read
triggered.
Bad: Future reads at that point will fail.

This fixes that issue.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    0344e3e View commit details
    Browse the repository at this point in the history

  2. always prefetch at least 5 blocks ahead 

    This should reduce stuttering when streaming.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    ff3efb5 View commit details
    Browse the repository at this point in the history

  3. test dag reader context cancellation 

    License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    5c0dc6a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2018

  1. explain when a promise can be canceled in pbdagreader 

    License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    7fd3404 View commit details
    Browse the repository at this point in the history