Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] coreapi: pubsub, dht, swarm #4774

Closed
wants to merge 11 commits into from
Closed

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 6, 2018

TODO:

  • Tests
  • Cleanup a bit
  • Review

I'm not sure what to do about the dht api - the commands expose some very verbose information which seems only useful for debugging, and I want to keep the api as simple as possible.

@ghost ghost assigned magik6k Mar 6, 2018
@ghost ghost added the status/in-progress In progress label Mar 6, 2018
@magik6k magik6k mentioned this pull request Mar 8, 2018
51 tasks
@magik6k
Copy link
Member Author

magik6k commented Mar 8, 2018

Random test fail in coreapi dht tests:

--- FAIL: TestDhtFindPeer (0.02s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x176e347]

goroutine 60 [running]:
testing.tRunner.func1(0xc4200fef00)
	/Users/travis/.gimme/versions/go1.9.darwin.amd64/src/testing/testing.go:711 +0x2d2
panic(0x1865da0, 0x203d7b0)
	/Users/travis/.gimme/versions/go1.9.darwin.amd64/src/runtime/panic.go:491 +0x283
github.com/ipfs/go-ipfs/core/coreapi_test.TestDhtFindPeer(0xc4200fef00)
	/Users/travis/gopath/src/github.com/ipfs/go-ipfs/core/coreapi/dht_test.go:29 +0x247
testing.tRunner(0xc4200fef00, 0x1aca698)
	/Users/travis/.gimme/versions/go1.9.darwin.amd64/src/testing/testing.go:746 +0xd0
created by testing.(*T).Run
	/Users/travis/.gimme/versions/go1.9.darwin.amd64/src/testing/testing.go:789 +0x2de
FAIL	github.com/ipfs/go-ipfs/core/coreapi	0.114s

This (FindPeer) and FindProviders seems to fail in about 1 out of 20 cases for me, not sure why.

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k magik6k requested a review from Kubuxu as a code owner March 10, 2018 17:10
@magik6k magik6k closed this Mar 10, 2018
@ghost ghost removed the status/in-progress In progress label Mar 10, 2018
This was referenced Mar 10, 2018
@magik6k magik6k deleted the feat/coreapi/pubsub-dht branch March 10, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant