Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx: update go-log #4637

Merged
merged 2 commits into from
Feb 3, 2018
Merged

gx: update go-log #4637

merged 2 commits into from
Feb 3, 2018

Conversation

Stebalien
Copy link
Member

No description provided.

@ghost ghost assigned Stebalien Feb 1, 2018
@ghost ghost added the status/in-progress In progress label Feb 1, 2018
@Stebalien Stebalien requested a review from frrist February 1, 2018 03:13
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the gx-workspace file, LGTM.

@@ -0,0 +1,93 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want to remove this before we merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien I want you to handwrite "I will not use 'git add .'" 100 times

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyrusleeping right after I add my updated .gitignore with git add ..

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@magik6k magik6k mentioned this pull request Feb 2, 2018
@whyrusleeping whyrusleeping merged commit d1a3fcc into master Feb 3, 2018
@whyrusleeping whyrusleeping deleted the gx/update-go-log branch February 3, 2018 23:30
@ghost ghost removed the status/in-progress In progress label Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants