Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow install.sh to be run without being the script dir #4547

Merged
merged 3 commits into from
Jan 6, 2018
Merged

Allow install.sh to be run without being the script dir #4547

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2eb40c
Allow install.sh to be run without being the script dir
epheph Jan 4, 2018
55d224a
Changing command substitution format
epheph Jan 5, 2018
bc3a761
fix bug with spaces in directory name
epheph Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/ipfs/dist/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
# Installation script for ipfs. It tries to move $bin in one of the
# directories stored in $binpaths.

bin=ipfs
INSTALL_DIR=$(dirname $0)

bin=$INSTALL_DIR/ipfs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more comment. Put the value here in quotes:

bin="$INSTALL_DIR/ipfs"

Otherwise any spaces in the INSTALL_DIR path will break this

binpaths="/usr/local/bin /usr/bin"

# This variable contains a nonzero length string in case the script fails
Expand Down