Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orphaned gx dependency: 2 #4422

Closed
wants to merge 1 commit into from
Closed

Fix orphaned gx dependency: 2 #4422

wants to merge 1 commit into from

Conversation

djdv
Copy link
Contributor

@djdv djdv commented Nov 24, 2017

#4403 caused the same issue as in #4400
gx dependency hash was not updated in mount_windows.go and causes builds to break on Windows. 🦃

76e1da0:

go install -ldflags="-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=76e1da02a"  ./cmd/ipfs
# github.com/ipfs/go-ipfs/commands
commands\request.go:124:35: option.DefaultVal undefined (type cmdkit.Option has no field or method DefaultVal)
make: *** [cmd/ipfs/Rules.mk:26: cmd/ipfs-install] Error 2

bcd2541:

go install -ldflags="-X "github.com/ipfs/go-ipfs/repo/config".CurrentCommit=bcd25416d"  ./cmd/ipfs
# github.com/ipfs/go-ipfs/core/commands
core\commands\mount_windows.go:12:10: cannot use "gx/ipfs/QmSNbH2A1evCCbJSDC6u3RV3GGDhgu6pRGbXHvrN89tMKf/go-ipfs-cmdkit".HelpText literal (type "gx/ipfs/QmSNbH2A1evCCbJSDC6u3RV3GGDhgu6pRGbXHvrN89tMKf/go-ipfs-cmdkit".HelpText) as type "gx/ipfs/QmUyfy4QSr3NXym4etEiRyxBLqqAeKHJuRdi8AACxg63fZ/go-ipfs-cmdkit".HelpText in field value
core\commands\mount_windows.go:18:26: cannot use "gx/ipfs/QmSNbH2A1evCCbJSDC6u3RV3GGDhgu6pRGbXHvrN89tMKf/go-ipfs-cmdkit".ErrNormal (type "gx/ipfs/QmSNbH2A1evCCbJSDC6u3RV3GGDhgu6pRGbXHvrN89tMKf/go-ipfs-cmdkit".ErrorType) as type "gx/ipfs/QmUyfy4QSr3NXym4etEiRyxBLqqAeKHJuRdi8AACxg63fZ/go-ipfs-cmdkit".ErrorType in argument to res.SetError
make: *** [cmd/ipfs/Rules.mk:26: cmd/ipfs-install] Error 2

License: MIT
Signed-off-by: Dominic DellaValle <ddvpublic@gmail.com>
@djdv djdv mentioned this pull request Nov 25, 2017
@djdv djdv closed this Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant