Add support for s3 backed ipfs repo #3726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
You didn't vendor s3. |
|
@Kubuxu No, not yet. I may have to make more changes to this and don't feel like publishing a whole bunch of packages during that process. |
|
closing this for now. The branch i based this on has changed significantly since i started it, and @b5 has done some great working making a better sql-datastore binding than did. Once #3575 gets merged, we can easily redo this PR using the better sql_datastore impl |
|
Only tangentially related, but just to connect the record, we've written an s3 datastore from a while back: https://github.com/qri-io/go-ds-s3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a definite WIP and relies (At a minimum) on the configurable datastore PR: #3575
Current usage requires creating a config on this branch (currently by running
ipfs init, will be making a new command for this soon) then editing the config to have s3 configuration (TODO: documentation on this). Then runningipfs init thatconfigfileto initialize a new ipfs node with an s3 backed repo.Initially, this will only be supported for new ipfs nodes, but we will add tools that allow migrations between different datastore formats.