misc: improve release checklist #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also prep it for templeating License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
misc/real-checklist/start-tmpl
branch
from
2e5d27f
to
9e2e249
Compare
misc/release-checklist.md
Outdated
| - [ ] release {{version}}-rcX on dist | ||
|
|
||
| ## release | ||
| - [ ] versions changed to {{version}}-rcX: |
misc/release-checklist.md
Outdated
| - [ ] in repo/config/version.go | ||
| - [ ] in package.json | ||
| - [ ] gx publish | ||
| - [ ] commit tagged |
There was a problem hiding this comment.
maybe mention that the tag must be signed?
whyrusleeping
requested changes
Feb 22, 2017
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
@Kubuxu why are the tests so angry about a change in the docs? |
whyrusleeping
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also prep it for templeating
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch