Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting in merkledag.go #3703

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Fix formatting in merkledag.go #3703

merged 1 commit into from
Feb 17, 2017

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Feb 17, 2017

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu
Fix formatting in merkledag.go
67a3a67 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu added the status/in-progress In progress label Feb 17, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 17, 2017

It is quite important as it is one of tests on Jenkins.

@kevina
Copy link
Contributor

kevina commented Feb 17, 2017

Note. I have two p.r. that touch merkledag.go #3671 and #3700. They both fix the formatting problems. If either of them are to go in within the next couple of days It would save me some trouble if this P.R. is closed without merging.

whyrusleeping
whyrusleeping approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping
Copy link
Member

@Kubuxu how did this get through in the first place? I thought gofmt was part of our normal test suite?

@whyrusleeping whyrusleeping merged commit bb35e40 into master Feb 17, 2017
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Feb 17, 2017
@whyrusleeping whyrusleeping deleted the fix/format-in-merkledag branch February 17, 2017 19:53
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 17, 2017

It was on teamcity, and is on Jenkins. Jenkins is almost working.

@Kubuxu Kubuxu added this to the ipfs 0.4.6 milestone Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ipfs 0.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @kevina @whyrusleeping