cmd/pubsub: fix peers command topic filtering #3484
Merged
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
added
need/review
Kubuxu
requested changes
Dec 8, 2016
| @@ -302,8 +305,13 @@ To use, the daemon must be run with '--enable-pubsub-experiment'. | |||
| return | |||
| } | |||
|
|
|||
| var topic string | |||
| if len(req.Arguments()) == 1 { | |||
There was a problem hiding this comment.
This will cause confusion if more topics are passed. IMO either error out or use all of them.
There was a problem hiding this comment.
The argument is optional and non-variadic. This means that passing two arguments will error.
whyrusleeping
force-pushed
the
fix/pubsub-peers-cmd
branch
from
b51f66d to
f104b8a
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
approved these changes
Dec 9, 2016
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3467
License: MIT
Signed-off-by: Jeromy why@ipfs.io